Require Xcode 13.0+, Swift 5.5+ #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
documentation
build
op-ex
CircleCI’s Xcode 13.0 image runs on macOS 11.5.2, which ArgumentParser no longer supports.
jill-cardamon
approved these changes
Aug 20, 2022
chezzdev
approved these changes
Aug 22, 2022
MaximAlien
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Carthage integration test builds on CircleCI now build in Xcode 13.0 and 14.0. The Swift Package manager integration test builds now build in Xcode 13.3.1 and 14.0. In general, the minimum supported Swift Package Manager version is 5.5, the same version that ships with Xcode 13.0.
#717 dropped Xcode 12 from CircleCI jobs that build the library using Xcode’s build system, but it left Xcode 12 in place for Carthage and SPM integration tests. I missed the latter in #725 when declaring that this library no longer supports Xcode 12. But I think we might as well say so formally, for all package managers, for consistency with the navigation SDK (mapbox/mapbox-navigation-ios#4063).
The App Store no longer accepts applications built in Xcode 12, so the only benefit to keeping Xcode 12 support would be Swift command line tools and macOS applications that don’t need to go through the App Store. Unlike the main library, the command line tool is not yet subject to the API stability guarantee.
The CircleCI configuration tests SPM integration in Xcode 13.3.1 because CircleCI’s Xcode 13 image runs on macOS 11.5.2, whereas ArgumentParser only supports macOS 12 and above.
/cc @mapbox/navigation-ios