Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses
SecurityException
thrown byAlarmManager
system service, which can be configured by OEMs (like Samsung) to limit number of alarms per process and as a result user would experience:Fatal Exception: java.lang.SecurityException: !@Too many alarms (500) registered from pid 9869 uid 10230
. Since we're using alarms as triggers for data uploads, we could potentially hit500
limit.Solution is to reuse pending intent which effectively means a single alarm will be reused for a single telemetry stream (we currently maintain 3 at most). In future the plan is to migrate to single alarm as trigger for data upload from all active telemetry data streams. Tested change with Samsung device in the cloud.