[libtelemetry] Add LocationEvent constructor that doesn't accept permissionStatus
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr1sunshine
force-pushed
the
mr1sunshine/bring-back-location-event-without-permission-status
branch
from
4347081
to
afc115f
Compare
pengdev
reviewed
Jun 7, 2022
libtelemetry/src/main/java/com/mapbox/android/telemetry/LocationEvent.java
Outdated
Show resolved
Hide resolved
…ermissionStatus` In #566 we added `permissionStatus` parameter to the `LocationEvent` constructor. That change actually introduced a breaking change in the public API surface. With this change, we are bringing an old constructor back and we use the `unknown` default value for the `permissionStatus`.
mr1sunshine
force-pushed
the
mr1sunshine/bring-back-location-event-without-permission-status
branch
from
afc115f
to
e6ee1a8
Compare
tarigo
approved these changes
Jun 7, 2022
pengdev
approved these changes
Jun 7, 2022
mr1sunshine
deleted the
mr1sunshine/bring-back-location-event-without-permission-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #566 we added
permissionStatusparameter to theLocationEventconstructor. That change actually introduced a breaking change in the public API surface.With this change, we are bringing an old constructor back and we use the
unknowndefault value for thepermissionStatus.