Add tests for any/all in filters

mapbox · Oct 10, 2017 · 452b92f · 452b92f
1 parent 81babb0
commit 452b92f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/style-spec/feature_filter/index.js b/src/style-spec/feature_filter/index.js
@@ -33,7 +33,7 @@ function isExpressionFilter(filter) {
     case 'any':
     case 'all':
         for (const f of filter.slice(1)) {
-            if (!isExpressionFilter(f)) {
+            if (!isExpressionFilter(f) && typeof f !== 'boolean') {
                 return false;
             }
         }

diff --git a/test/unit/style-spec/feature_filter.test.js b/test/unit/style-spec/feature_filter.test.js
@@ -25,6 +25,18 @@ test('expression, compare two properties', (t) => {
     t.end();
 });
 
+test('expression, any/all', (t) => {
+    t.equal(filter(['all'])(), true);
+    t.equal(filter(['all', true])(), true);
+    t.equal(filter(['all', true, false])(), false);
+    t.equal(filter(['all', true, true])(), true);
+    t.equal(filter(['any'])(), false);
+    t.equal(filter(['any', true])(), true);
+    t.equal(filter(['any', true, false])(), true);
+    t.equal(filter(['any', false, false])(), false);
+    t.end();
+});
+
 test('expression, type error', (t) => {
     t.throws(() => {
         filter(['==', ['number', ['get', 'x']], ['string', ['get', 'y']]]);