Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greater label density in 0.7 makes some more important labels disappear #1066

Closed
fnicollet opened this issue Mar 6, 2015 · 5 comments
Closed

Comments

@fnicollet
Copy link
Contributor

Hello,

Just updated to 0.7 and the result is very different. Here is a screenshot of version 0.5.2:
image

And a screenshot of the same zoom level in version 0.7.0 (from the CDN)
image

There was an accepted PR about labels density (#989) and it is true, there is more road labels but they seem to take over on labels with more importance such as higher admin_*. You can see that the neighbourhoods are not visible anymore, apart from one on the right of the screen.

Is that expected behaviours? Should there not be some kind of priorities between labels?

Thanks,
Fabien

@kristfal
Copy link

Following up on this, not sure if related. I'm seeing some issues "symbol-placement": "line" at the moment which were not present before #989 was accepted.

Symbol line placement overlap is wonky. See attached screenshot. The line label has no allow-overlap, is listed at the very end of the stylesheet, yet still overlap all other labels. The overlapped labels may have "symbol-placement": "line" or "point".

screenshot 2015-03-11 11 01 52

@ansis
Copy link
Contributor

ansis commented Mar 18, 2015

@fnicollet that looks like a style problem. I opened an issue here: mapbox/mapbox-gl-styles#41

@kristfal can you check if the problem still exists with the latest master? we just merged a rewrite of label placement: #1079

@kristfal
Copy link

@ansis Still seeing line issues after building the latest master, same issue on GL native (not the most recent master) as well, but significantly fewer collisions in the same places.

Also noticed that two line labels from the same line can collide at certain zoom levels (screenshot nr 2).

screenshot 2015-03-19 13 40 18
screenshot 2015-03-19 13 40 59
screenshot 2015-03-19 13 42 04

@jfirebaugh
Copy link
Contributor

0.8.1 has significant labeling changes and Mapbox Streets looks OK to me. Neighborhoods do defer to streets at a certain level but I think that's a stylistic choice.

@kristfal If you're still seeing labeling issues with 0.8.1, please open a separate ticket. Thanks!

@fnicollet
Copy link
Contributor Author

Thanks for this feedback on that issue. 0.8.1 indeed has more street labels (still cropped at times, but that's another issue), it's ok if they hide the neighbourhood labels that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants