Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blurring #236

Closed
kkaefer opened this issue Jan 15, 2014 · 8 comments
Closed

Add blurring #236

kkaefer opened this issue Jan 15, 2014 · 8 comments
Assignees

Comments

@kkaefer
Copy link
Contributor

kkaefer commented Jan 15, 2014

We should add a composite operation that blurs the framebuffer onto the back buffer.

Ideally, we'd use mipmap blurs, but that requires power-of-2 framebuffer sizes.

@springmeyer
Copy link
Contributor

Interested in how blurring will work at edges of tiles or data. See some of the possible artifacts I've been grappling with in Mapnik at mapnik/mapnik#2165.

@kkaefer
Copy link
Contributor Author

kkaefer commented Feb 27, 2014

We're probably going to do a full scene blur and not restrict them to tiles.

@springmeyer
Copy link
Contributor

excellent.

@tmcw
Copy link
Contributor

tmcw commented Mar 14, 2014

This would happen in drawComposited? https://github.com/mapbox/llmr/blob/master/js/render/drawcomposited.js#L14

@kkaefer
Copy link
Contributor Author

kkaefer commented Mar 17, 2014

@tmcw yes

@tmcw
Copy link
Contributor

tmcw commented Mar 17, 2014

Grabbing

@ansis
Copy link
Contributor

ansis commented May 16, 2014

Ideally, we'd use mipmap blurs, but that requires power-of-2 framebuffer sizes.

mipmap blurs and the other option seem to be for varying levels of blur for a static image. mipmap blurs involve blurring a downscaled version on the cpu. Since we're blurring dynamically drawn stuff, this probably won't work for us?

@mourner mourner added this to the future milestone Jun 24, 2014
@ansis
Copy link
Contributor

ansis commented Jul 22, 2014

done in #564

@ansis ansis closed this as completed Jul 22, 2014
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
remove event listeners on remove - fixes mapbox#169, fixes mapbox#236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants