Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display an error when calling setFilter on a non-existent layer ID #2597

Closed
jfirebaugh opened this issue May 20, 2016 · 0 comments
Closed

Display an error when calling setFilter on a non-existent layer ID #2597

jfirebaugh opened this issue May 20, 2016 · 0 comments
Labels
good first issue

Comments

@jfirebaugh
Copy link
Contributor

Currently, calling setFilter with an ID of a layer that does not exist produces "Uncaught TypeError: Cannot read property 'ref' of undefined". Instead, it should report an error using the same mechanism as when other runtime style API constraints are violated.
@lucaswoj lucaswoj changed the title setFilter on a non-existent layer ID should report an error Display an error when calling setFilter on a non-existent layer ID Jul 29, 2016
stepankuzmin added a commit to stepankuzmin/mapbox-gl-js that referenced this issue Dec 26, 2016
@stepankuzmin
throw an error when calling layer operating functions with a non-exis…
32ed7f4 
…tent layer ID mapbox#2597
@stepankuzmin stepankuzmin mentioned this issue Dec 26, 2016
Merged
stepankuzmin added a commit to stepankuzmin/mapbox-gl-js that referenced this issue Dec 26, 2016
@stepankuzmin
add tests for mapbox#2597
d68802e
stepankuzmin added a commit to stepankuzmin/mapbox-gl-js that referenced this issue Jan 3, 2017
@stepankuzmin
emit an error instead of throwning mapbox#2597
a666523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfirebaugh @lucaswoj