Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyline with duplicate coordinate at the end not rendered correctly #4579

Closed
jaapster opened this issue Apr 12, 2017 · 6 comments
Closed

Polyline with duplicate coordinate at the end not rendered correctly #4579

jaapster opened this issue Apr 12, 2017 · 6 comments
Assignees
Labels

Comments

@jaapster
Copy link

See this example.

A polygon is not always rendered correctly when the last two coordinates are identical.
In the example, when you remove the last coordinate the polygon is rendered correctly.

@kkaefer
Copy link
Contributor

kkaefer commented Apr 12, 2017

The last two coordinates of your polygon are identical, if you remove one of them, the polygon renders correctly.

@mourner
Copy link
Member

mourner commented Apr 12, 2017

@kkaefer that's in the description. :)
@jaapster the behavior is indeed weird. Also noting that a similar bug happens if you change the type to MultiLineString, meaning that it's not about polygons.

@jaapster
Copy link
Author

@mourner For good measure I tried the coordinates with type "LineString. That yields a similar result although the "gap" is positioned slightly differently.

@mourner mourner self-assigned this Apr 14, 2017
@mourner mourner changed the title Polygon not rendered correctly Polyline with duplicate coordinate at the end not rendered correctly Apr 24, 2017
@mourner
Copy link
Member

mourner commented Apr 24, 2017

Not a GeoJSON-VT issue. Looking into the GL line tesselation code now...

@mourner
Copy link
Member

mourner commented Apr 24, 2017

Fixed in #4634

@jaapster
Copy link
Author

Thanks @mourner!

YunjieLi pushed a commit that referenced this issue Jun 2, 2017
- this is simpler than predicting opacity based on current zooming speed
- this is smoother: symbols don't flicker when changing zoom speed or
  when zooming in and out rapidly.

1df1466

fix #4562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants