add overdraw inspector #2489
Merged
add overdraw inspector #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -374,3 +377,20 @@ Painter.prototype.setExMatrix = function(exMatrix) { | |||
| Painter.prototype.lineWidth = function(width) { | |||
| this.gl.lineWidth(util.clamp(width, this.lineWidthRange[0], this.lineWidthRange[1])); | |||
| }; | |||
|
|
|||
| Painter.prototype.overdrawInspector = function(enabled) { | |||
There was a problem hiding this comment.
Can we make this method name a verb instead of a noun? i.e. setOverdrawInspector
There was a problem hiding this comment.
I'm going to change this to showOverdrawInspector to match the external property.
The overdraw inspector shows how many time each fragment has been shaded. White fragments were shaded 8 or more times. Black fragments were shaded 0 times. Lower is better. `map.showOverdrawInspector = true` turns it on.
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overdraw inspector shows how many time each fragment has been shaded. White fragments were shaded 8 or more times. Black fragments were shaded 0 times. Lower is better.
This only counts shaded fragments that were written to the color buffer. Fragments that are written only to the stencil buffer are not included.
map.showOverdrawInspector = true
mapbox-streets landuse overdraws a lot:
mapbox-streets terrain overdraws a lot:👀 @kkaefer @mourner @lucaswoj