-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fake "browser" and "dom" modules #3106
Conversation
@@ -1,29 +1,46 @@ | |||
'use strict'; | |||
|
|||
/** | |||
* Unlike js/util/browser.js, this code is written with the expectation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description was specific to the browser version of browser.js, and can be removed or rewritten.
Can we merge this as-is and go for canvas, ajax, and web_worker in a followup PR? I'd like to write some |
@jfirebaugh Sure! I'll fix this up and merge shortly. |
The coverage dropped because the test-suite didn't run. This error did not fail the build:
|
Test suite is failing because no fill outlines are being drawn but CI is still passing. This is a fun one 😂 |
|
Easy fix! We weren't using the |
Force pushed to resolve merge conflicts. This should be 🍏 and ready to 🚢 . |
This PR removes the fake "browser" and "dom" modules used in the test environment in favor of using the real modules with jsdom.
This is a follow-up to #3063
Checklist