Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure animation loop stops after raster tiles fade in #3764

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Dec 8, 2016

PR #3532 introduced a bug wherein the render loop never stops when rendering raster tiles.

Raster tiles interact with the animation loop to allow them to fade in per raster-fade-duration.

This PR improves our handling of raster tile fading to prevent the animation loop from running continuously.

fixes #3757

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • post benchmark scores
  • manually test the debug page

@mapsam mapsam removed the request for review from friedbunny December 8, 2016 01:10
Copy link
Contributor

@friedbunny friedbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I REQUEST THAT I REVIEW THIS PR.

@friedbunny friedbunny dismissed their stale review December 8, 2016 01:12

This was a joke.

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending a fixed build (failing in source cache for some reason) and preferably some tests.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Dec 9, 2016

Found the problem causing the unit tests to fail @mourner. Glad to see the unit tests are working 😅

@lucaswoj lucaswoj merged commit 1d762f6 into master Dec 13, 2016
@lucaswoj lucaswoj deleted the raster-animation-loop branch December 13, 2016 23:53
@AndyMoreland
Copy link
Contributor

Hey folks,

This PR looks like it addresses the high cpu usage we've been seeing lately on our map. This is causing pretty significant pain for us because our users tend to have several complicated maps running at once.

Do y'all have any notion of when you might release an 0.29.0? Happy to cherry-pick this onto the private fork that I deploy off of, but if you're planning on releasing soon I'll hold off since it's the holidays.

Totally understand if you don't want to discuss release schedules publicly but I figured I'd try asking :-).

Andy

@mollymerp
Copy link
Contributor

Hi @AndyMoreland,
Glad this solves some issues for you! We don't have a finite schedule for the next release but we should have one out before the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image layer seems to trigger render loop and consume CPU without interaction
5 participants