Need highp precision for gamma values on mobile devices #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowp triggers aliasing artifacts at larger font sizes: mapbox/mapbox-gl-native#7599.
anandthakker
approved these changes
Feb 15, 2017
jfirebaugh
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Feb 15, 2017
Need highp precision for gamma values on mobile devices. lowp triggers aliasing artifacts at larger font sizes. Note that this change is a hand-edit to the generated shader sources, rather than pulling mapbox/mapbox-gl-js#4275 and running the generator script. The reason for that is that the upstream shader now assumes support for DDS properties that gl-native does not yet support. Once that support lands in gl-native, we can regenerate the shader source.
jfirebaugh
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Feb 15, 2017
Need highp precision for gamma values on mobile devices. lowp triggers aliasing artifacts at larger font sizes. Note that this change is a hand-edit to the generated shader sources, rather than pulling mapbox/mapbox-gl-js#4275 and running the generator script. The reason for that is that the upstream shader now assumes support for DDS properties that gl-native does not yet support. Once that support lands in gl-native, we can regenerate the shader source.
jfirebaugh
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Feb 15, 2017
Need highp precision for gamma values on mobile devices. lowp triggers aliasing artifacts at larger font sizes. Note that this change is a hand-edit to the generated shader sources, rather than pulling mapbox/mapbox-gl-js#4275 and running the generator script. The reason for that is that the upstream shader now assumes support for DDS properties that gl-native does not yet support. Once that support lands in gl-native, we can regenerate the shader source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lowptriggers aliasing artifacts at larger font sizes: mapbox/mapbox-gl-native#7599.