move markers to the best world for the current view #4452
Conversation
andrewharvey
force-pushed
the
draw-markers-in-other-worlds
branch
from
133dd6b
to
fdd3f18
Compare
src/util/util.js
Outdated
| @@ -4,6 +4,7 @@ | |||
| const UnitBezier = require('@mapbox/unitbezier'); | |||
| const Coordinate = require('../geo/coordinate'); | |||
| const Point = require('point-geometry'); | |||
| const LngLat = require('../geo/lng_lat'); | |||
There was a problem hiding this comment.
This creates a circular dependency between util/util.js and geo/lng_lat.js (which uses util.wrap). Which seems to be causing an issue. Investigating...
There was a problem hiding this comment.
I've removed the circular dependency by moving the bestWorld function out of util/util.
andrewharvey
changed the title
andrewharvey
changed the title
|
Alternatively, instead of a separate util file, we could add a |
|
Tagging @mourner for review on this one as he's the most familiar with this part of the code & similar code in Leaflet. |
andrewharvey
force-pushed
the
draw-markers-in-other-worlds
branch
from
4a927b2
to
1a16a70
Compare
@mourner Agreed, it feels much cleaner and better style this way. I've made the change and squashed commits. |
I wanted to add a unit test, but it it didn't seem very easy as I'd need to check the DOM Element CSS transform. |
andrewharvey
force-pushed
the
draw-markers-in-other-worlds
branch
from
1a16a70
to
d538b07
Compare
jfirebaugh
force-pushed
the
draw-markers-in-other-worlds
branch
from
d538b07
to
c75bca9
Compare
jfirebaugh
force-pushed
the
draw-markers-in-other-worlds
branch
from
10b5a7f
to
db5b218
Compare
Launch Checklist
DOM Elements like Markers and Popups are only drawn in world 0. However when you're close to the anti-meridian, DOM Elements which should appear might not, and in some cases it makes sense to draw the DOM elements in world -1 and 1.
This aims to address #3770. However until #2071 is fixed, this PR only addresses issues when the view is in world 0.
public LngLat.wrapToWorld(center) added JS doc.
I did some manual testing of this, with both a marker and popup around long 170 and at long -170, and it works well for world -1, 0 and 1, so long as the camera always wraps to world 0 this is enough.
When zoomed out the marker/popup will jump which might be a poor UX, but I think it's okay and probably better than the alternative of it disappearing off the view.