Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use highp for color attributes #4476

Merged
merged 2 commits into from
Mar 22, 2017

Conversation

anandthakker
Copy link
Contributor

Use highp for all color attributes, because as of mapbox/mapbox-gl-native#8267 two color components may be packed into a single float, a process which assumes that at least 16 bits are available.

Refs mapbox/mapbox-gl-native#8385

Launch Checklist

  • briefly describe the changes in this PR
  • post benchmark scores
  • manually test the debug page
benchmark master 9941dde
map-load 140 ms
style-load 115 ms
buffer 1,061 ms
fps 60 fps
frame-duration 5.2 ms, 0% > 16ms
query-point 1.21 ms
query-box 65.76 ms
geojson-setdata-small 6 ms
geojson-setdata-large 199 ms

Anand Thakker and others added 2 commits March 22, 2017 13:08
anandthakker pushed a commit to mapbox/mapbox-gl-native that referenced this pull request Mar 22, 2017
Addresses #8385

Updates shaders to reflect mapbox/mapbox-gl-js#4476
@anandthakker anandthakker merged commit dc426c2 into release-ios-v3.5.0-android-v5.0.0 Mar 22, 2017
@anandthakker anandthakker deleted the highp-color branch March 22, 2017 18:27
@anandthakker anandthakker restored the highp-color branch March 22, 2017 18:27
@anandthakker anandthakker deleted the highp-color branch March 22, 2017 18:28
anandthakker added a commit to mapbox/mapbox-gl-native that referenced this pull request Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants