gl-style-composite throws error on conflicting source layer names #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
Apr 17, 2017
| "source": "mapbox-b" | ||
| }] | ||
| }); | ||
| }, 'Conflicting source layer names', 'throws error on conflicting source layer names'); |
There was a problem hiding this comment.
'Conflicting source layer names' ⇢ /Conflicting source layer names/
andrewharvey
force-pushed
the
gl-style-composite-conflicting-source-layers
branch
from
0ef0ded
to
b615368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Make gl-style-composite executable in line with the other tools.
A style without source compositing can have layers referencing different source-layers with the same name but from different sources. Source compositing these styles is undefined as it could create a name conflict.
Studio asks users what they want to do in this case:
This PR causes the gl-style-composite utility to throw an error if a name conflict would occur.
I'm not sure who else is using the utility and how, but I feel throwing an error and pushing it back to the user to resolve the conflicts first is probably the better way to go...