Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which properties can use exponential and interval functions in docs #4693

Merged
merged 1 commit into from Jun 28, 2017

Conversation

samanpwbb
Copy link
Contributor

Small fix to docs, @jfirebaugh for review. I went with "requires a property that can be interpolated" instead of "requires an interpolatable property" because "interpolated" is a keyword from the spec JSON that people might be searching for on the page.

@samanpwbb samanpwbb requested a review from jfirebaugh May 9, 2017 20:58
@jfirebaugh
Copy link
Contributor

Ah shoot, I misunderstood your question and misread the docs. "The domain must be numeric" is actually correct. Note: domain, not range. Both interval and exponential functions require numeric domain values -- they are either zoom functions, or property or zoom-and-property functions with numeric property values.

@jfirebaugh
Copy link
Contributor

jfirebaugh commented May 9, 2017

We should say something about the range/output type though.

For exponential:

The domain (input value) must be numeric, and the style property must support interpolation. Style properties that support interpolation are marked with ◢, and exponential is the default function type for these properties.

For interval:

The domain (input value) must be numeric. Any style property may use interval functions. For properties marked with 📶, the "interval" symbol, this is the default function type.

@jfirebaugh jfirebaugh merged commit 2444050 into mb-pages Jun 28, 2017
@jfirebaugh jfirebaugh deleted the clarify-docs branch June 28, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants