Fix bug with rerendering map after webglcontexlost #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On IE 11 and Edge map sometimes stops refreshing (loading new content).
It is caused by webglcontextlost event being fired while frame is rendered. (easiest way to reproduce is to run frame-duration benchmark several times on IE)
After webglcontextrestored event is fired map tries to rerender itself by calling
resize()and then move event fires which calls_rerender().Hovewer it hits condition
if (this.style && !this._frameId)and stops.this._frameIdis not cleared, map cannot rerender and stops rendering new content.This pull request cleares
map._frameIdwhen webglcontextlost event is fired so it enables proper rendering restoration after losing webgl context.Launch Checklist