migrate to ci 2.0 #4939
migrate to ci 2.0 #4939
Conversation
mollymerp
force-pushed
the
circle2
branch
6 times, most recently
from
2d4da4d
to
8dd7b25
Compare
|
Looks like the build is down to about 8 minutes for v2 from 11-12 minutes in v1 |
.circleci/config.yml
Outdated
| jobs: | ||
| build: | ||
| docker: | ||
| - image: mbgl/ci:r4-linux-clang-3.9 |
There was a problem hiding this comment.
Does this image have awscli pre-installed? We should use one that does, so we can remove that from dependencies.sh.
.circleci/config.yml
Outdated
| - run: | ||
| name: install dependencies | ||
| command: | | ||
| bash ./.circleci/dependencies.sh |
There was a problem hiding this comment.
Let's move the yarn install part of this to its own run step, to measure the time independently.
.circleci/config.yml
Outdated
| name: deploy if tagged | ||
| when: on_success | ||
| command: | | ||
| if [[ $CIRCLE_TAG =~ v[0-9]+\.[0-9]+\.[0-9]+(\-dev)? ]]; then |
There was a problem hiding this comment.
It looks like something is off about this conditional; https://circleci.com/gh/mapbox/mapbox-gl-js/8468 ran deploy.sh but it wasn't a tagged build.
There was a problem hiding this comment.
I think it was a tagged build unless I'm missing something 🤔 I made (and subsequently deleted) a v0.0.0-dev tag to test out the conditional.
mollymerp
force-pushed
the
circle2
branch
2 times, most recently
from
6912d12
to
75f5ce4
Compare
|
Switched to a gl-js specific image – PR here mapbox/mbgl-ci-images#8 |
|
blerg I do not know why this test is failing – its passing when I run the render tests inside the docker image locally 💭 |
mollymerp
force-pushed
the
circle2
branch
7 times, most recently
from
b582932
to
35cc3f3
Compare
mollymerp
force-pushed
the
circle2
branch
10 times, most recently
from
5889954
to
07ec287
Compare
mollymerp
force-pushed
the
circle2
branch
9 times, most recently
from
0440355
to
aec582c
Compare
try running with npm instead of yarn uncomment nyc try new circle2 tag support please run
mollymerp
force-pushed
the
circle2
branch
2 times, most recently
from
539b794
to
3a39337
Compare
mollymerp
force-pushed
the
circle2
branch
3 times, most recently
from
97e98ef
to
fc2db79
Compare
|
😂 moving to workflows with the newly added 2.0 tag filter support fixed the failing test 🤷♀️ and increasing our |
|
we'll have to un-require the old ci/circleci build in the settings in order to merge this. |
close #4905
there are a couple failing render tests but the diff is very small (looks like tile boundary is 1 px off), so I may increase the allowable diff for those tests unless someone else has another idea.
I also still need to test the deploy script with a test tag
cc @jfirebaugh @kkaefer
Launch Checklist