-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable map recycling option when running render tests in GL JS #5092
Conversation
bfb4797
to
d22e450
Compare
Changing the semantics of the |
@anandthakker suggested we could listen to the |
^ Yep, that should work in the |
package.json
Outdated
"test-suite-clean": "find test/integration/*-tests -mindepth 2 -type d -not \\( -exec test -e \"{}/style.json\" \\; \\) -print | xargs -t rm -r", | ||
"test-unit": "tap --reporter dot --no-coverage test/unit", | ||
"test-render": "node --max-old-space-size=2048 test/render.test.js", | ||
"test-render-recycle-map": "node --max-old-space-size=2048 test/render.test.js --recycle-map", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yarn test-render --recycle-map
should work, which would make this unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but I had to append --
before the script arguments:
yarn test-render -- --recycle-map
d22e450
to
fbb67c3
Compare
fbb67c3
to
c0a278d
Compare
circle.yml
Outdated
@@ -38,6 +38,12 @@ workflows: | |||
filters: | |||
tags: | |||
only: /.*/ | |||
- test-render-recyrcle-map: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recyrcle-map
looks like a typo
Causes the 'load' event to be fired again when setting a new style.
e8c43f7
to
a302a95
Compare
Is this ready to merge? |
This is stale - requires rebase + logic update to avoid changing |
Closing here but without prejudice towards updating with the needed changes and resubmitting -- would be nice to have this. |
Enables map recycling option when running render tests in GL JS.
Depends on #5091 to be merged first.
This PR:
load
event to be fired again when setting a style after a previous set style.options.recycleMap
.