Add ignores for https://github.com/mapbox/mapbox-gl-js/issues/5102 #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't aware we were getting local failures of this test -- it passes locally on my machine (macOS 10.12.6). Looks like the cause is something like different implementations of gl.LINES for the tile boundaries? It's already ignored on the native side in part for that reason (mapbox/mapbox-gl-native#3841). I don't think the tile boundaries are an important part of this test -- I'd rather drop them and keep the test running on at least the gl-js side than have the test ignored on both platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.