Split "curve" into "step" and "interpolate" #5542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
curve-step-interpolate
branch
from
f95f06c
to
2d3a54a
Compare
|
Blocked on posting benchmark results by #5543. |
anandthakker
approved these changes
Oct 27, 2017
|
@anandthakker I'd say no, better break hard early. Alias would be good to help with the transition, but there's not enough adoption of expressions yet to delay the break. |
jfirebaugh
force-pushed
the
curve-step-interpolate
branch
from
2d3a54a
to
8fb99f5
Compare
|
I kept it an error, but with a custom error message indicating the new operators. |
jfirebaugh
force-pushed
the
curve-step-interpolate
branch
from
85d06c3
to
ecc92b5
Compare
jfirebaugh
force-pushed
the
curve-step-interpolate
branch
from
ecc92b5
to
646fca8
Compare
|
https://bl.ocks.org/anonymous/raw/0faddf4a07f92862b32b0d2dfeff39bf/ (no significant changes) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5528. Will make sure all the right people get a heads up before this is merged.