Stub out Map#_rerender in paint benchmarks #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5543. Internal rendering changes were causing one of the conditions on the call to _rerender inside _render to be true, whereas before it was apparently always false. _rerender caused an animation frame to be requested, but then the resulting frameId would be reset via the benchmark's own call to _render. The result was a backlog of animation frame requests, some of which completed after teardown.
jfirebaugh
force-pushed
the
paint-benchmarks
branch
from
c527360
to
3021803
Compare
lbud
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5543. Internal rendering changes were causing one of the conditions on the call to _rerender inside _render to be true, whereas before it was apparently always false. _rerender caused an animation frame to be requested, but then the resulting frameId would be reset via the benchmark's own call to _render. The result was a backlog of animation frame requests, some of which completed after teardown.