Refactor symbol buffer related types #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
reviewed
Dec 21, 2017
src/symbol/symbol_layout.js
Outdated
| @@ -292,12 +292,11 @@ function addTextVertices(bucket: SymbolBucket, | |||
| writingMode, | |||
| anchor, | |||
| lineArray.lineStartIndex, | |||
| lineArray.lineLength, | |||
| bucket.placedGlyphArray); | |||
| lineArray.lineLength); | |||
|
|
|||
| // The placedGlyphArray is used at render time in drawTileSymbols | |||
There was a problem hiding this comment.
This comment needs updating.
ChrisLoer
approved these changes
Dec 21, 2017
Using the same type for both was oversharing.
jfirebaugh
force-pushed
the
symbol-collision-buffers
branch
from
c086163
to
bf018cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to have a separate
CollisionBufferstype, rather than trying to shoehorn those duties intoSymbolBuffers.