Add documentation clarifying stop output value type #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be a bit more precise, we could say "Output values must be literal values (i.e. not functions or expressions), and appropriate for the property. For example stop output values for a function used in the |
|
@jfirebaugh Thanks for the suggestion. I made those changes. |
jfirebaugh
suggested changes
Jan 6, 2018
docs/pages/style-spec.js
Outdated
| input value and one output value is known as a "stop." Stop output values | ||
| must be literal values (i.e. not functions or expressions), and appropriate | ||
| for the property. For example, stop output values for a function used in | ||
| the `fill-color` property must be <a href="#types-color">colors</a>. |
There was a problem hiding this comment.
Replace the markdown around fill-color with markup.
|
@jfirebaugh It was unclear to me whether to use |
jfirebaugh
approved these changes
Jan 8, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today I was trying an expression as the output of a stop value. There were cryptic errors, but I didn't find in the spec whether this was supposed to work or not. @jfirebaugh clarified in chat that this shouldn't work, so I thought I'd try amending the docs.
I also corrected a spacing problem.
Before:
After: