Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotate icon in animate a point along a route example #6554

Merged
merged 2 commits into from Apr 24, 2018

Conversation

andrewharvey
Copy link
Collaborator

@andrewharvey andrewharvey commented Apr 22, 2018

Launch Checklist

  • briefly describe the changes in this PR

closes #4767 by rotating the icon along the route

screenshot

  • n/a write tests for all new functionality
  • n/a document any changes to public APIs
  • n/a post benchmark scores
  • manually test the debug page

@andrewharvey
Copy link
Collaborator Author

I see a trend here... all three open PRs targeting mb-pages are stuck with CI saying "Expected — Waiting for status to be reported".

Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew!

I updated the branch settings so that only the appropriate builds are required -- so you should be able to merge all the mb-pages PRs once approved.

@@ -115,7 +121,8 @@
"type": "symbol",
"layout": {
"icon-image": "airport-15",
"icon-rotate": 90,
"icon-rotate": { "type": "identity", "property": "bearing"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the function with ["get", "bearing"]. (We decided to always use expressions in examples.)

@andrewharvey andrewharvey merged commit a3b0852 into mb-pages Apr 24, 2018
@andrewharvey andrewharvey deleted the 4767-animate-point-along-route-example branch April 24, 2018 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants