add animationFrameProvider
map option
#8131
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows the user to implement
requestAnimationFrame
andcancelAnimationFrame
in order to synchronize map rendering with their external rendering. While it is generally recommended to let the browser schedule map rendering frames this may be useful for synchronizing with external content in some cases (fix #7893).This could also be useful for synchronizing multiple maps.
As an alternative to synchronous render frames
#7893 explains the reasons why synchronous rendering is necessary in some cases. An
animationFrameProvider
option seemed preferable to implementing amap.synchronousRepaint()
because:Launch Checklist
@mourner @ryanhamley does this approach seem preferable? Or would it be better just implement a
map.synchronousRender()
?