fix opacity interpolation for composition expressions #8818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #8817 The interpolation factor could be outside of the range 0..1 which could result in rendering errors.
| "width": 64, | ||
| "height": 64, | ||
| "operations": [ | ||
| ["pauseSource", "geojson"], |
There was a problem hiding this comment.
Would be great to have a comment explaining why pauseSource is needed for this test.
asheemmamoowala
approved these changes
Sep 27, 2019
|
@ansis should we check whether we clamp opacity interpolation for composition expressions in gl-native? even if we can't reproduce this specific bug, is there any reason we might not want to clamp it if it's not already? |
ansis
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Oct 1, 2019
ansis
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8817
The interpolation factor could be outside of the range 0..1 which could result in rendering errors.
This fix clamps the value to the correct range and adds a regression test cover the fix.
Launch Checklist
@mapbox/gl-nativeif this PR includes shader changes or needs a native portI'm not sure if this bug exists in mapbox-gl-native.