This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Cherrypick vanillashake #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add styleable snapshotter. * Add style API for snapshotter * Add observer interface to snapshotter * WIP Add styling to snapshotter activity * Update interface and implement addlayer functions. * Deprecate methods instead of removing * Implement addSource functions. * Implement addImage function * Still use the previous callback interface. * Expose onStyleDidloaded interface * Add setStyle method * Start native snapshotter from start method * Fix snapshotter test. * Fix check style * Keep the original interface * Update gl-native * Add demo for snapshotter heatmap layer * bump gl-native Co-authored-by: Alexander Shalamov <alexander.shalamov@mapbox.com> (cherry picked from commit da6d8a2)
* Expose snapshotter layer and source objects * Add example snapshotter + within activity * Bump vendor/mapbox-gl-native (cherry picked from commit 6984dbf)
(cherry picked from commit 4b0cd40)
(cherry picked from commit fbea14a)
chloekraw
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Looks good, this includes everything we need for the release once #296 is pulled in.
Since there are no merge conflicts and we're pulling the commits directly onto the branch, the changes here should be safe even without a thorough review; I'll give this an approval so you're not blocked. Feel free to wait for someone from @mapbox/maps-android to take a look though.
(cherry picked from commit 585253e)
tobrun
approved these changes
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #287 and resolves #285