Merge pull request #14898 from mapbox/tvn-allow-null-updates

Allow null updates to GeoJsonSource#setGeoJson
mapbox · Jun 11, 2019 · e3d87ed · e3d87ed
1 parent 314032d
commit e3d87ed
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/...id/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/sources/GeoJsonSource.java b/...id/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/sources/GeoJsonSource.java
@@ -4,7 +4,6 @@
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.support.annotation.UiThread;
-
 import com.mapbox.geojson.Feature;
 import com.mapbox.geojson.FeatureCollection;
 import com.mapbox.geojson.Geometry;
@@ -287,14 +286,14 @@ public void setGeoJson(Geometry geometry) {
    *
    * @param featureCollection the GeoJSON FeatureCollection
    */
-  public void setGeoJson(FeatureCollection featureCollection) {
+  public void setGeoJson(@Nullable FeatureCollection featureCollection) {
     if (detached) {
       return;
     }
     checkThread();
 
-    List<Feature> features = featureCollection.features();
-    if (features != null) {
+    if (featureCollection != null && featureCollection.features() != null) {
+      List<Feature> features = featureCollection.features();
       List<Feature> featuresCopy = new ArrayList<>(features);
       nativeSetFeatureCollection(FeatureCollection.fromFeatures(featuresCopy));
     } else {