Some macOS tests on release-boba are failing (mostly color related)

[julianrex]

Platform: macOS
Mapbox SDK version: release-boba at b79a1cc

The test target is failing (either from the macosapp or CI schemes). Log is attached: Test CI_2018-02-22T17-10-13.txt

The bulk of the errors appear to be related to Wide Color support in High Sierra.

Quoting @friedbunny:

It being High Sierra-related makes sense, as Circle is still on (Low) Sierra: https://circle-macos-docs.s3.amazonaws.com/image-manifest/build-298/index.html

They seem mostly color-related, but -[MGLNSStringAdditionsTests testTitleCasedString] is also failing.

cc @1ec5

[1ec5]

The bulk of the errors appear to be related to Wide Color support in High Sierra.

Apparently the errors expose a previously latent issue in the macOS SDK: the SDK itself uses the calibrated RGB color space, but the calibration changed in High Sierra with the introduction of Wide Color support. The intended color space in mbgl is probably sRGB, because that’s the color space used by CSS.

They seem mostly color-related, but -[MGLNSStringAdditionsTests testTitleCasedString] is also failing.

I originally fixed this issue for both iOS and macOS in 016eacb for #10224, but 7f13509 in the same PR broke the tests on macOS by assuming the code only runs on iOS.

/cc @frederoni

[1ec5]

Fixed in #11391 on the release-boba branch for macOS map SDK v0.7.0.