This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Backport Xcode 9 & build fixes to v3.6.x release branch #10224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
approved these changes
Oct 18, 2017
| @@ -19,7 +19,7 @@ - (void)testTitleCasedString { | |||
|
|
|||
| XCTAssertEqualObjects([@"Improve the map" mgl_titleCasedStringWithLocale:locale], @"Improve the Map"); | |||
| XCTAssertEqualObjects([@"Improve The Map" mgl_titleCasedStringWithLocale:locale], @"Improve The Map"); | |||
|
|
|||
There was a problem hiding this comment.
Nit: whitespace only change
There was a problem hiding this comment.
This was in the original commit, so I’ve just let it be. 🤷♂️
|
Node tests on Travis fail on this branch because of #9940, which we’ve decided not to fix. |
This was referenced Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports (cherry-picks) #10055 and #10070 to the
release-ios-v3.6.0-android-v5.1.0branch so that potential patch releases will have (mostly) passing tests./cc @kkaefer @frederoni