Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Symbols can flicker when they exists in two world copies at once #13478

Closed
ChrisLoer opened this issue Nov 29, 2018 · 1 comment
Closed

Symbols can flicker when they exists in two world copies at once #13478

ChrisLoer opened this issue Nov 29, 2018 · 1 comment
Assignees
@ChrisLoer
Labels
bug

Comments

@ChrisLoer
Copy link
Contributor

Native equivalent of mapbox/mapbox-gl-js#7639.

Because OverscaledTileID::isChildOf ignores wrap, it will report that a tile with wrap X is a child of a tile in wrap Y. This can cause the CrossTileSymbolIndex to share cross tile IDs between symbols in two different world copies, which can cause flicker since the two copies are placed separately.

cc @ansis
@ChrisLoer ChrisLoer added the bug label Nov 29, 2018
@ChrisLoer ChrisLoer self-assigned this Nov 29, 2018
ChrisLoer added a commit that referenced this issue Nov 29, 2018
@ChrisLoer
[core] OverscaledTileID::isChildOf should check wrap values.
2cfbf57 
Fixes issue #13478
@ChrisLoer ChrisLoer mentioned this issue Nov 29, 2018
Merged
ChrisLoer added a commit that referenced this issue Nov 30, 2018
@ChrisLoer
[core] OverscaledTileID::isChildOf should check wrap values.
f87ef3f 
Fixes issue #13478
@ChrisLoer
Copy link
Contributor Author

Fixed in #13479.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChrisLoer ChrisLoer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisLoer