Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Allow InfoWindow to be open while panning #3121

Closed
tobrun opened this issue Nov 25, 2015 · 4 comments
Closed

Allow InfoWindow to be open while panning #3121

tobrun opened this issue Nov 25, 2015 · 4 comments
Labels
Android Mapbox Maps SDK for Android feature

Comments

@tobrun
Copy link
Member

tobrun commented Nov 25, 2015

We’re hearing of the need to improve our InfoWindow setup.

We identified two improvements:

I'm working on the same branch as #3115 to be able to identify performance problems early on.

cc @zugaldia @incanus @bleege

@tobrun
Copy link
Member Author

tobrun commented Nov 25, 2015

I was able to sync SurfaceView changes to the overlain default InfoWindow while still being performant. Now I need to investigate if it is still performant to sync a repositioned InfoWindow as landed in #2273.

The code required to reposition in #2273 is more complex as used in current progress, because this is a hot code path we need to watch out for performance loss.

Standard InfoWindow can be viewed here.
Custom InfoWindowAdapter can be viewed here

@tobrun tobrun added Android Mapbox Maps SDK for Android feature labels Nov 25, 2015
@tobrun tobrun added this to the android-v2.3.0 milestone Nov 25, 2015
@tobrun
Copy link
Member Author

tobrun commented Nov 25, 2015

I was able to also sync the repositioned InfoWindow from #2273

Progress can be viewed here

Just need to clean up the code and PR.

tobrun added a commit that referenced this issue Nov 25, 2015
…dard InfoWindow (without repositioning InfoWindowTipView) to be panned above the map
@tobrun
Copy link
Member Author

tobrun commented Nov 25, 2015

@zugaldia I already pushed the code to your branch. So we can have 👀 on progress and you can continue your work. Will clean up / optimise later today

@zugaldia
Copy link
Member

@tobrun Great job, let's clean up the code and make sure we aren't creating any unexpected leaks and then we're ready for a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android feature
Projects
None yet
Development

No branches or pull requests

3 participants