Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

marker support #60

Closed
incanus opened this issue Feb 11, 2014 · 8 comments
Closed

marker support #60

incanus opened this issue Feb 11, 2014 · 8 comments
Labels
feature GL JS parity For feature parity with Mapbox GL JS
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented Feb 11, 2014

Something I'd like to see is applying marker imagery points on the map, using a quad tree for efficiency, anti-rotating against angle changes to remain upright, and supporting z-indexing (markers closer to the bottom of the screen are in front of those closer to the top).

Basic POIs are done over in WebGL:

What I want is the ability to replace this from the SDK:

https://dl.dropboxusercontent.com/u/575564/rotatepins.mov

I'm going to start working on this.

@kkaefer
Copy link
Contributor

kkaefer commented Feb 12, 2014

WebGL isn't using a quad tree.

@incanus
Copy link
Contributor Author

incanus commented Feb 12, 2014

Yeah, seeing this as I dig in. I will keep at this as a port over from current WebGL functionality, despite us possibly throwing this away as I'd like to get a bit more familiar with the whole style/bucket/parse/tag/vertex/shader/render flow we have for things like lines and fills.

After getting basic POI working, I'll look into arbitrary external content (GeoJSON/whatever) for drawing actual markers.

@incanus
Copy link
Contributor Author

incanus commented Feb 13, 2014

Getting there.

img_0598

@incanus incanus mentioned this issue Feb 13, 2014
Closed
@incanus incanus self-assigned this Feb 13, 2014
This was referenced Feb 14, 2014
@incanus
Copy link
Contributor Author

incanus commented Feb 15, 2014

Breaking this down a bit:

  • Get POI in the current stylesheet to render.
  • Build out more POI in stylesheet as on WebGL.
  • Handle arbitrary point data (GeoJSON etc.) with configurable markers.

incanus added a commit that referenced this issue Feb 15, 2014
 * add basic marker style to stylesheet
 * pass through marker style to PBF conversion
 * marker/point tile parsing, bucket, buffer, shaders, etc.
 * new sprite hosting for 1x/2x variants
 * sprite load accepts screen scale argument
kkaefer added a commit that referenced this issue Feb 21, 2014
refs #60: first cut of POI rendering
@incanus
Copy link
Contributor Author

incanus commented Feb 21, 2014

First task done; next up is more Maki in the stylesheet, which hopefully looks better, then arbitrary data, which is a bigger hurdle.

@incanus
Copy link
Contributor Author

incanus commented May 3, 2014

Making progress on GeoJSON support. Most of the feature tiling is done. Will round that out + bucket parsing + rendering next.

@incanus
Copy link
Contributor Author

incanus commented May 6, 2014

Ok, parsing properly and rendering... almost properly. Problem is related to what @kkaefer is working on with universal clip id's so that we can have multiple sources overlaid.

Right now I only get masking in tiles where the route overlaps, but then don't get the baselayer actually drawing there (exclusive clip id's):

screen shot 2014-05-06 at 3 08 21 pm

I'm going to get #167 merged into master, then break this out into another pull that depends on the clip id work before getting merged.

But basically at this point we can throw arbitrary GeoJSON LineString features into llmr-native and have them pre-tiled and just about rendered.

@incanus
Copy link
Contributor Author

incanus commented May 7, 2014

Closing in favor of #170.

@incanus incanus closed this as completed May 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

2 participants