Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android SDK renaming #10609

Merged
merged 4 commits into from
Dec 4, 2017
Merged

Android SDK renaming #10609

merged 4 commits into from
Dec 4, 2017

Conversation

langsmith
Copy link
Contributor

This pr renames Android content that needs to be renamed, to Mapbox Maps SDK for Android .

This is a part of #10385, which is the effort to rename various Mapbox Maps SDKs.

@langsmith langsmith self-assigned this Nov 30, 2017
@langsmith langsmith changed the title Android SDK renaming Android SDK renaming *work in progress* Nov 30, 2017
@langsmith
Copy link
Contributor Author

@tobrun & @zugaldia , I believe this pr is good to go. It adjusts everything in this repo that I think is worth adjusting. Two things to be aware of:

  1. I didn't change mentions of the Android SDK in the javadocs of various classes within the SDK. Figured that it was self-explanatory and that we didn't need naming continuity down to that deep of a level.

  2. Should the attribution title string resource be adjusted? 🤔 As of this writing, I've haven't pushed the change to this pr. Here's what the attribution dialog looks like with the longer title 👇

device-2017-11-30-142810

@langsmith langsmith changed the title Android SDK renaming *work in progress* Android SDK renaming Nov 30, 2017
@1ec5
Copy link
Contributor

1ec5 commented Dec 1, 2017

I didn't change mentions of the Android SDK in the javadocs of various classes within the SDK. Figured that it was self-explanatory and that we didn't need naming continuity down to that deep of a level.

Can we refer to it as “the Android map SDK” in that case, to avoid confusion with the Android navigation SDK?

@zugaldia
Copy link
Member

zugaldia commented Dec 1, 2017

Can we refer to it as “the Android map SDK” in that case,

Wouldn't it be “the Android maps SDK”?

Should the attribution title string resource be adjusted?

I vote adjusting it to the new longer name ("Mapbox Maps SDK for Android").

@1ec5
Copy link
Contributor

1ec5 commented Dec 1, 2017

Can we refer to it as “the Android map SDK” in that case,

Wouldn't it be “the Android maps SDK”?

Ugh, yeah, I keep forgetting we long ago standardized on excessive pluralization around here. 😉 Maps SDK it is.

@langsmith
Copy link
Contributor Author

Ok, so green javadocs will have Android Maps SDK and attribution title will be Mapbox Maps SDK for Android

@langsmith
Copy link
Contributor Author

good to go here @zugaldia

@langsmith langsmith merged commit cb5dc2e into master Dec 4, 2017
@langsmith langsmith deleted the ls-android-sdk-renaming branch December 4, 2017 16:21
jmkiley pushed a commit that referenced this pull request Dec 4, 2017
Android SDK renaming (#10609)
b115059 
* changes in various markdown files

* more tweaks

* Updated attribution title
tobrun pushed a commit that referenced this pull request Dec 19, 2017
@tobrun
Android SDK renaming (#10609)
2ad1bea 
* changes in various markdown files

* more tweaks

* Updated attribution title
@tobrun tobrun mentioned this pull request Dec 19, 2017
Merged
tobrun pushed a commit that referenced this pull request Dec 19, 2017
@tobrun
Android SDK renaming (#10609)
0b98436 
* changes in various markdown files

* more tweaks

* Updated attribution title
tobrun pushed a commit that referenced this pull request Dec 19, 2017
@tobrun
Android SDK renaming (#10609)
c15c6ed 
* changes in various markdown files

* more tweaks

* Updated attribution title
@tobrun tobrun added this to the android-v5.3.0 milestone Dec 20, 2017
@tobrun tobrun mentioned this pull request Dec 20, 2017
Closed
22 tasks
mappy-mobile pushed a commit to Mappy/mapbox-gl-native that referenced this pull request Dec 26, 2017
Merge branch 'mapbox_release_5.3' into mappy_mergre_mapbox_5.2.1
bc3e16e 
* mapbox_release_5.3: (25 commits)
  [android] - update changelog for 5.3.0
  [android] added map touch listeners api based on lists
  [android] Tweak TinySDF docs to better describe font-family behavior.
  Saving/restoring MyLocationViewSettings (mapbox#10746) (mapbox#10748)
  [android] Updated Spanish, Vietnamese translations
  Android SDK renaming (mapbox#10609)
  [android] - use default icon when compass icon fails to decode (mapbox#10694)
  [android] - remove startup flash from fragment, rework OnMapReady callback for multiple listeners (mapbox#10717)
  [android] Add Configuration hook for local ideograph font family and demo activity
  [android] Android implementation of local CJK glyph rendering  - Draws bold version of glyph if font stack contains string "bold"  - Not hooked up to global configuration yet
  [core] Hook LocalGlyphRasterizer "font family" configuration up to Renderer
  [core] Enable local glyph generation using TinySDF.  - Platform-specific LocalGlyphRasterizer is responsible for deciding which glyphs to rasterize locally and for implementing the rasterization.  - Default platform implementation doesn't locally generate any glyphs -> no behavior change  - Unit test uses StubLocalGlyphRasterizer, which returns a single fixed bitmap for all CJK glyphs  - Rename glyph_loader.test to glyph_manager.test
  [core] C++ port of TinySDF
  [ios, macos] Cleaned up base localization files
  [android] - update instrumented make target, move code style validation before building C++ code, replace code style checks with the wrapper code style check. (mapbox#10724)
  [android] - activate filesource when creating an offline region (mapbox#10718)
  [ios] update constraints when updating content inset
  [ios] Fix an Interface Builder crash for IBInspectable properties.
  [ios] Fix the content insets for the scale and compass view.
  Post camera listener invocations (mapbox#10690)
  ...

# Conflicts:
#	platform/android/MapboxGLAndroidSDK/gradle.properties
#	platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java
#	platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapGestureDetector.java
#	platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
#	platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxMap.java
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zugaldia zugaldia zugaldia approved these changes

@tobrun tobrun Awaiting requested review from tobrun

Assignees

@langsmith langsmith

Labels
documentation
Projects
None yet
Milestone
android-v5.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@langsmith @1ec5 @zugaldia @kkaefer @tobrun