Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

add max & min latitude and longitude constants to maps sdk #10780

Merged
merged 1 commit into from
Jan 2, 2018
Merged

add max & min latitude and longitude constants to maps sdk #10780

merged 1 commit into from
Jan 2, 2018

Conversation

osana
Copy link
Contributor

@osana osana commented Dec 21, 2017

closes #10729

@osana osana added the Android Mapbox Maps SDK for Android label Dec 21, 2017
@osana osana added this to the android-v6.0.0 milestone Dec 21, 2017
@osana osana force-pushed the osana-minmax-latlng-10729 branch 4 times, most recently from 8e21116 to a3f8456 Compare December 21, 2017 21:28
asheemmamoowala
asheemmamoowala suggested changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to reference the Mercator projection in the comments except for the capped latitude.
MAX_MERCATOR_LATITUDE represents the capped latitude for spherical Mercator projections.

...droid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/constants/GeometryConstants.java Outdated
public static final int RADIUS_EARTH_METERS = 6378137;

/**
* A Mercator project has a finite longitude values, this constant represents the lowest value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell out projection

@osana osana force-pushed the osana-minmax-latlng-10729 branch 2 times, most recently from 0651044 to 020b623 Compare December 22, 2017 12:41
@osana osana force-pushed the osana-minmax-latlng-10729 branch 2 times, most recently from ebe1763 to 1571c5e Compare January 2, 2018 14:37
@osana osana merged commit 814c87f into master Jan 2, 2018
@osana osana deleted the osana-minmax-latlng-10729 branch January 2, 2018 17:43
@tobrun tobrun mentioned this pull request Jan 26, 2018
Closed
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees

@tobrun tobrun

@cammace cammace

@asheemmamoowala asheemmamoowala

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v6.0.0-boba
Development

Successfully merging this pull request may close these issues.

[android] add max & min latitude and longitude constants to maps sdk
4 participants
@osana @tobrun @asheemmamoowala @cammace