This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Log failed http request url #10830
Merged
Log failed http request url #10830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
10825-log-url-failed-request
branch
from
cf5cb44
to
9c39198
Compare
LukasPaczos
approved these changes
Jan 5, 2018
tobrun
force-pushed
the
10825-log-url-failed-request
branch
from
9c39198
to
1a5e35a
Compare
LukasPaczos
suggested changes
Jan 5, 2018
| @@ -180,6 +181,9 @@ private void onFailure(Exception e) { | |||
| // PERMANENT_ERROR | |||
| Timber.w("Request failed due to a permanent error: %s", errorMessage); | |||
| } | |||
| if (logRequestUrl) { | |||
| Timber.v(call.request().url().toString()); | |||
There was a problem hiding this comment.
Can we give some more context to this log and maybe make it a Timber.w()? Alternatively, we could include it in above logs with simplified if.
| @@ -217,4 +221,8 @@ private String getApplicationIdentifier() { | |||
| static void enableLog(boolean enabled) { | |||
| logEnabled = enabled; | |||
| } | |||
|
|
|||
| static void enablePrintRequestUrlOnFaillure(boolean enabled) { | |||
| @@ -16,4 +16,20 @@ | |||
| public static void setLogEnabled(boolean enabled) { | |||
| HTTPRequest.enableLog(enabled); | |||
| } | |||
|
|
|||
| /** | |||
| * Enable printing of the request url when a error occurred. Default value is false. | |||
tobrun
force-pushed
the
10825-log-url-failed-request
branch
2 times, most recently
from
8a55f2b
to
96696ea
Compare
|
@LukasPaczos, revisited the approach taken, instead of the if/else construct, I went with the |
LukasPaczos
approved these changes
Jan 9, 2018
tobrun
force-pushed
the
10825-log-url-failed-request
branch
from
96696ea
to
3db6bdc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10825.
cc @danswick