This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Use the correct cancelable callback after posting cancel #10871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvm-cancel-callback
branch
2 times, most recently
from
7f64b0b
to
d489154
Compare
LukasPaczos
approved these changes
Jan 9, 2018
| new Handler().post(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| invalidateCameraPosition(); |
There was a problem hiding this comment.
Any particular reason for posting invalidateCameraPosition() instead of invoking it right away?
Otherwise looks good! :)
tobrun
force-pushed
the
tvm-cancel-callback
branch
2 times, most recently
from
460e609
to
5d791f8
Compare
tobrun
force-pushed
the
tvm-cancel-callback
branch
from
5d791f8
to
87b0115
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reached out about the change introduced in #10664. When an animation is started while another is ongoing, the onCancel callback of the newer animation will be invoked instead of the callback of the old animation.