This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Allow changing the used OkHttpClient #10948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
approved these changes
Jan 17, 2018
This was referenced Jan 17, 2018
tobrun
force-pushed
the
tvn-expose-http-client
branch
from
1dc0e00
to
58af5bf
Compare
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-expose-http-client
branch
from
58af5bf
to
24745ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing from an end user that they need to be able to add Interceptors to requests made by the SDK. To also improve integration for issues as #9640 it makes more sense allow setting an external OkHttpClient instead of exposing the existing one (eg. SSLSocketFactory can only be added as part of the builder).