Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

add binding integration for RasterDEMSource #11031

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jan 24, 2018

closes #11025, this PR adds binding integration for RasterDEMSource + example:

image

Todo:

  • add javadoc
  • move camera position to a location with hills in example
  • add HillshadeLayer below label layers in example

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jan 24, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Jan 24, 2018
@tobrun tobrun self-assigned this Jan 24, 2018
Copy link
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*
* @param nativePtr - pointer to native peer
*/
public RasterDemSource(long nativePtr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be package protected / private if only used through JNI

@tobrun tobrun merged commit a4546a8 into master Jan 25, 2018
@tobrun tobrun deleted the tvn-add-raster-dem-source branch January 25, 2018 11:54
@tobrun tobrun mentioned this pull request Jan 26, 2018
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Peer RasterDEMSource missing
2 participants