This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Blacklist adreno 2xx for VAO support #11047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
suggested changes
Jan 25, 2018
src/mbgl/gl/context.cpp
Outdated
| // https://bugs.chromium.org/p/chromium/issues/detail?id=510637 | ||
| // https://chromium.googlesource.com/chromium/src/gpu/+/master/config/gpu_driver_bug_list.json#2316 | ||
| // Blacklist Vivante GC4000 due to bugs when linking loaded programs: | ||
| // https://github.com/mapbox/mapbox-gl-native/issues/10704 | ||
| const std::string renderer = reinterpret_cast<const char*>(glGetString(GL_RENDERER)); | ||
| if (renderer.find("Adreno (TM) 3") != std::string::npos | ||
| if (renderer.find("Adreno (TM) 2") != std::string::npos |
There was a problem hiding this comment.
This blacklists program binaries, not VAO. The check for VAO blacklisting is a few lines further up ;)
There was a problem hiding this comment.
🤦♂️ should be in order with 42633a3
tobrun
force-pushed
the
tvn-blacklist-adreno-2xx
branch
9 times, most recently
from
42633a3
to
6fd373b
Compare
tobrun
force-pushed
the
tvn-blacklist-adreno-2xx
branch
from
6fd373b
to
8102872
Compare
|
@kkaefer would you be able to re-review this PR? |
kkaefer
approved these changes
Jan 29, 2018
|
Capturing from mapbox/mapbox-navigation-android#534 (comment) that the impacted device is now working without crashing. Thank you @kkaefer for 👀 'ing and proposing the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing from @kkaefer in mapbox/mapbox-navigation-android#534 (comment) that we should try blacklisting Adreno 2xx GPU for VAO support to potentially resolve the crash mentioned in the upstream ticket.