This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Backport: Continue loading style even if we mutate it #11294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Feb 23, 2018
kkaefer
force-pushed
the
release-agua__continue-style-loading-despite-mutation
branch
from
33e99f6
to
97cf61a
Compare
Alternative fix to #11288, until we figure out a proper async_hooks implementation.
When we load a stale style from cache, and the user immediately starts mutating it, we should continue loading the style so that we'll get a fresh copy of the data into our cache and avoid perpetually showing the stale style.
kkaefer
force-pushed
the
release-agua__continue-style-loading-despite-mutation
branch
from
97cf61a
to
9261d5d
Compare
kkaefer
deleted the
release-agua__continue-style-loading-despite-mutation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #11270