This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Rework logical condition convenience expressions #11555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-logical-expressions-rework-api
branch
from
376cd54
to
dd47abd
Compare
LukasPaczos
approved these changes
Mar 30, 2018
LukasPaczos
force-pushed
the
tvn-logical-expressions-rework-api
branch
from
15a6bdc
to
dbcbbbe
Compare
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reworking our DDS examples to the new API, we noticed that the current convenience methods of logical conditions of something as
eq(String, String)didn't make much sense. This is because IRL you will use at least one expression in there. This PR addresses this by change the syntax to use one epxresssion and one literal value.