Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Throw exception when converting PropertyValue with an expression #11572

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Mar 30, 2018

This PR catches the common pitfall of using a PropertyValue inside an expression. This typically occurs when a user migrates from the old dds approach to the new expression syntax.

  • look into alternative approach of getting the value from the PropertyValue instead?

closes #11572

…rt an PropertyValue as an expression literal
@tobrun tobrun added the Android Mapbox Maps SDK for Android label Mar 30, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Mar 30, 2018
@tobrun tobrun self-assigned this Mar 30, 2018
@tobrun tobrun requested a review from LukasPaczos March 30, 2018 21:08
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think separation is better than fixing behind the scenes the mix up of concepts.

@LukasPaczos LukasPaczos merged commit 1730756 into release-boba Apr 4, 2018
@LukasPaczos LukasPaczos deleted the tvn-throw-excpetion-propertyvalue branch April 4, 2018 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants