Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] updated mapbox-sdk-services to 3.0.1 #11593

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Conversation

osana
Copy link
Contributor

@osana osana commented Apr 4, 2018

@osana osana requested a review from LukasPaczos April 4, 2018 14:20
@osana osana mentioned this pull request Apr 4, 2018
14 tasks
@LukasPaczos LukasPaczos added this to the android-v6.0.0 milestone Apr 4, 2018
@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Apr 4, 2018
@osana osana force-pushed the osana-mas3.0.1 branch 7 times, most recently from 558bebf to c9e1e74 Compare April 4, 2018 23:52
@osana
Copy link
Contributor Author

osana commented Apr 4, 2018

Upgrade to MAS 3.0.1 resulted in the error below.
Note that I was able to build and run test app with no problems.


* What went wrong:
Execution failed for task ':MapboxGLAndroidSDKTestApp:transformClassesAndResourcesWithProguardForRelease'.
> Job failed, see logs for details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 51s
56 actionable tasks: 29 executed, 27 up-to-date
Exception in thread "Thread-146" java.lang.NoClassDefFoundError: com/android/utils/PathUtils$1
    at com.android.utils.PathUtils.deleteIfExists(PathUtils.java:47)
    at com.android.utils.PathUtils.lambda$addRemovePathHook$0(PathUtils.java:125)
    at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: com.android.utils.PathUtils$1
    at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
    ... 3 more
Makefile:622: recipe for target 'apackage' failed
make: *** [apackage] Error 1
Exited with code 2

Search for similar problems shows that other people have been having similar issue and that could be related to https://issuetracker.google.com/issues/69380617

Also here is a similar problem in another github project kiwix/kiwix-android#518 I think they resolved it by upgrading to to Android Gradle Plugin 3.1.0 from 3.0.1 ( the one we have).

@osana
Copy link
Contributor Author

osana commented Apr 5, 2018

Tried bumping Android Gradle Plugin to 3.1.0

as per https://developer.android.com/studio/releases/gradle-plugin.html#updating-gradle
that means gradle wrapper should be at 4.4
and build tools 27.0.3

@osana
Copy link
Contributor Author

osana commented Apr 5, 2018

cc @tobrun @LukasPaczos

@tobrun
Copy link
Member

tobrun commented Apr 5, 2018

@osana CI is failing because it doesn't support 27.0.3, see the dockerfile in https://github.com/mapbox/mbgl-ci-images/blob/master/android-ndk-r16b/Dockerfile#L43. I'm waiting for the release of 28.0.0, which is now in RC.1, to update the CI images. I'm not seeing why we need to bump these items if I take a look at the mapbox-java configuration. Will dig a little bit deeper to find the root cause.

@osana
Copy link
Contributor Author

osana commented Apr 5, 2018

@tobrun I cannot reproduce the build problem building locally so this was a bit of experimentation. I will update the branch back to just updating MAS version so that you could see the error.

@osana osana merged commit 275d753 into release-boba Apr 5, 2018
@tobrun tobrun mentioned this pull request Apr 11, 2018
10 tasks
@tobrun tobrun deleted the osana-mas3.0.1 branch July 23, 2018 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants