This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Mark -presentCalloutFromRect:inView:constrainedToView:animated: unavailable #11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available (constrainedToRect variant supersedes)
|
/cc @jmkiley |
friedbunny
added
the
SEMVER-MAJOR
platform/ios/CHANGELOG.md
Outdated
| @@ -52,6 +52,8 @@ The 4.0._x_ series of releases will be the last to support iOS 8. The minimum iO | |||
| * The `MGLMapView.selectedAnnotations` property (backed by `-[MGLMapView setSelectedAnnotations:]`) now selects annotations that are off-screen. ([#9790](https://github.com/mapbox/mapbox-gl-native/issues/9790)) | |||
| * The `animated` parameter to `-[MGLMapView selectAnnotation:animated:]` now controls whether the annotation and its callout are brought on-screen. If `animated` is `NO` then the annotation is selected if offscreen, but the map is not panned. Currently only point annotations are supported. Setting the `MGLMapView.selectedAnnotations` property now animates. ([#3249](https://github.com/mapbox/mapbox-gl-native/issues/3249)) | |||
| * Fixed a crash when rapidly adding and removing annotations. ([#11551](https://github.com/mapbox/mapbox-gl-native/issues/11551), [#11575](https://github.com/mapbox/mapbox-gl-native/issues/11575)) | |||
| * Marked protocol method `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToView:animated:]` as unavailble. Please use `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToRect:animated:]` instead (enabling moving off-screen annotations on-screen). | |||
There was a problem hiding this comment.
What do you think about the following blurb:
There was a problem hiding this comment.
This change is really about removing potential confusion; adding support for moving off-screen annotations came in an earlier release No it wasn't 😄. Let me tweak.
friedbunny
approved these changes
Apr 19, 2018
platform/ios/CHANGELOG.md
Outdated
| @@ -52,6 +52,8 @@ The 4.0._x_ series of releases will be the last to support iOS 8. The minimum iO | |||
| * The `MGLMapView.selectedAnnotations` property (backed by `-[MGLMapView setSelectedAnnotations:]`) now selects annotations that are off-screen. ([#9790](https://github.com/mapbox/mapbox-gl-native/issues/9790)) | |||
| * The `animated` parameter to `-[MGLMapView selectAnnotation:animated:]` now controls whether the annotation and its callout are brought on-screen. If `animated` is `NO` then the annotation is selected if offscreen, but the map is not panned. Currently only point annotations are supported. Setting the `MGLMapView.selectedAnnotations` property now animates. ([#3249](https://github.com/mapbox/mapbox-gl-native/issues/3249)) | |||
| * Fixed a crash when rapidly adding and removing annotations. ([#11551](https://github.com/mapbox/mapbox-gl-native/issues/11551), [#11575](https://github.com/mapbox/mapbox-gl-native/issues/11575)) | |||
| * Marked protocol method `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToView:animated:]` as unavailble. Please use `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToRect:animated:]` instead (enabling moving off-screen annotations on-screen). | |||
There was a problem hiding this comment.
“unavailble” → unavailable
platform/ios/CHANGELOG.md
Outdated
| @@ -52,6 +52,8 @@ The 4.0._x_ series of releases will be the last to support iOS 8. The minimum iO | |||
| * The `MGLMapView.selectedAnnotations` property (backed by `-[MGLMapView setSelectedAnnotations:]`) now selects annotations that are off-screen. ([#9790](https://github.com/mapbox/mapbox-gl-native/issues/9790)) | |||
| * The `animated` parameter to `-[MGLMapView selectAnnotation:animated:]` now controls whether the annotation and its callout are brought on-screen. If `animated` is `NO` then the annotation is selected if offscreen, but the map is not panned. Currently only point annotations are supported. Setting the `MGLMapView.selectedAnnotations` property now animates. ([#3249](https://github.com/mapbox/mapbox-gl-native/issues/3249)) | |||
| * Fixed a crash when rapidly adding and removing annotations. ([#11551](https://github.com/mapbox/mapbox-gl-native/issues/11551), [#11575](https://github.com/mapbox/mapbox-gl-native/issues/11575)) | |||
| * Marked protocol method `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToView:animated:]` as unavailble. Please use `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToRect:animated:]` instead (enabling moving off-screen annotations on-screen). | |||
There was a problem hiding this comment.
Link to this PR at the end of the line.
fabian-guerra
approved these changes
Apr 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.