This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Check if renderer is not destroyed before delivering snapshot #11800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
May 2, 2018
This was referenced May 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are posting the snapshot callback back to the main thread, from the render thread, the Activity can be already destroyed and therefore the peer is destroyed as well. This PR adds a check if the renderer (therefore the
NativeMapViewpeer) is not destroyed before delivering the callback.Also, I removed changes from #11358 as they seem obsolete now, not 100% sure as I wasn't able to reproduce the issue presented in the #11358 after removing that workaround anyway. @tobrun would you mind rechecking that? Happy to bring them back if it's still an issue.