This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Expose MapView created callbacks on MapFragment #11934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-fragment-view-callback
branch
from
92ffea2
to
0283c8a
Compare
LukasPaczos
approved these changes
May 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google made a u-turn at i/o this year when it comes to advising to use fragments to build an UI. Since they are now considered first class citizens this PR adds the ability to get a callback when the MapView has been created. Users have reached out in the past to get a reference to the underlying mapview when using our fragments, the callback in this PR makes it easier for them.