This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Fix keypath expressions, json object is parsed incorrectly for nested keypaths. #11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
May 21, 2018
| NSArray *expressionObject; | ||
| for (NSString *pathComponent in self.keyPath.pathComponents.reverseObjectEnumerator) { | ||
| NSMutableArray *expressionObject; | ||
| NSArray *keyPath = [self.keyPath componentsSeparatedByString:@"."]; |
There was a problem hiding this comment.
Ooh, good catch – I was probably thinking of NSString.stringByDeletingPathExtension here.
| if (expressionObject) { | ||
| expressionObject = @[@"get", pathComponent, expressionObject]; | ||
| [expressionObject addObject:@[@"get", pathComponent]]; |
There was a problem hiding this comment.
map.box.gl should become ["get", "gl", ["get", "box", ["get", "map"]]], not ["get", "gl", ["get", "box"], ["get", "map"]].
fabian-guerra
force-pushed
the
fabian-keypath-11874
branch
3 times, most recently
from
1f5809c
to
41fd7c8
Compare
1ec5
approved these changes
May 23, 2018
platform/ios/CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
|
|
|||
| * Unknown tokens in URLs are now preserved, rather than replaced with an empty string. ([#11787](https://github.com/mapbox/mapbox-gl-native/issues/11787)) | |||
| * Adjusted when and how the camera transition update and finish callbacks are called, fixing recursion bugs. ([#11614](https://github.com/mapbox/mapbox-gl-native/pull/11614)) | |||
| * Fixed an issue preventing nested `keyPath` expressions get parsed accordingly to the spec. ([#11959](https://github.com/mapbox/mapbox-gl-native/pull/11959)) | |||
There was a problem hiding this comment.
Nit: replace keyPath with “key path” so developers don’t think this issue was limited to the +[NSExpression expressionForKeyPath:] initializer.
…ctly for nested keypaths.
fabian-guerra
force-pushed
the
fabian-keypath-11874
branch
from
41fd7c8
to
73cf88b
Compare
|
Added the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11874