Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Remove support for Fabric #12126

Merged
merged 3 commits into from
Jun 12, 2018
Merged

[android] Remove support for Fabric #12126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
487b955
[android] remove fabric properties file
zugaldia Jun 11, 2018
cb8211d
[android] fabric.properties no longer present
zugaldia Jun 11, 2018
dfd429f
[android] fabric step in release.py no longer necessary
zugaldia Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions platform/android/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ gradle/configuration.gradle
# Token file
MapboxGLAndroidSDKTestApp/src/main/res/values/developer-config.xml

# Twitter Fabric / Crashlytics
fabric.properties

# Capture files
captures/

Expand Down
3 changes: 0 additions & 3 deletions ...GLAndroidSDK/src/main/resources/fabric/com.mapbox.mapboxsdk.mapbox-android-sdk.properties
View file
Open in desktop

This file was deleted.

7 changes: 1 addition & 6 deletions platform/android/scripts/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@
MAPBOX_GL_ANDROID_SDK_PATH = '../MapboxGLAndroidSDK'
GRADLE_PROPERTIES_PATH = '%s/gradle.properties' % MAPBOX_GL_ANDROID_SDK_PATH
GRADLE_TOKEN = 'VERSION_NAME='
FABRIC_PROPERTIES_PATH = '%s/src/main/resources/fabric/com.mapbox.mapboxsdk.mapbox-android-sdk.properties' % MAPBOX_GL_ANDROID_SDK_PATH
FABRIC_TOKEN = 'fabric-version='

# Triggers a new build, returns a summary of the build
URL_CIRCLECI = 'https://circleci.com/api/v1.1/project/github/mapbox/mapbox-gl-native/tree/' # + :branch
Expand Down Expand Up @@ -144,10 +142,7 @@ def publish_final(branch, version):
dirty_gradle = update_current_version(file_path=GRADLE_PROPERTIES_PATH, file_var=GRADLE_TOKEN, version=version)
if dirty_gradle:
git_add(path=GRADLE_PROPERTIES_PATH)
dirty_fabric = update_current_version(file_path=FABRIC_PROPERTIES_PATH, file_var=FABRIC_TOKEN, version=version)
if dirty_fabric:
git_add(path=FABRIC_PROPERTIES_PATH)
if dirty_gradle or dirty_fabric:
if dirty_gradle:
git_commit_and_push(branch=branch, version=version)
do_circleci_request(branch=branch)

Expand Down